Targets make check + make test: Fix fallout of prior toplevel "make all" #37

Merged

Jan Lindemann merged 1 commit from jan/feature/20260625-test-help-fail-over-missing-toplevel-make-all into master 2026-06-25 18:53:15 +02:00 AGit

Conversation 0 Commits 1 Files changed 2 +130 -3

Jan Lindemann commented 2026-06-25 17:35:51 +02:00

Owner

Copy link

After a pipeline change, CI now runs "make all" in a repo's root, which uncovers two problems:

1. The help integration test only succeeded as long CI didn't run "make all" before "make test". That way, the checked out repository lacked the generated __init__.py files needed for some modular subcommands to be fully loaded, and hence, the test should have failed. The entire machinery only worked because the subcommands in question are not not essential to building jw-pkg itself: secrets and posix. So, this commit adapts the help integration test to the new reality.

2. Regarding python-tools.sh: Commit 55060486 satisfies yapf in some places of the source code, but in others not anylonger. So patch python-tools.sh's newline handling again.

While not thematically similar, both fixes get baked into one commit to satisfy the requirement that every single commit needs to pass make clean all check test individually.

After a pipeline change, CI now runs "make all" in a repo's root, which uncovers two problems: 1. The help integration test only succeeded as long CI didn't run "make all" before "make test". That way, the checked out repository lacked the generated `__init__.py` files needed for some modular subcommands to be fully loaded, and hence, the test should have failed. The entire machinery only worked because the subcommands in question are not not essential to building jw-pkg itself: `secrets` and `posix`. So, this commit adapts the help integration test to the new reality. 2. Regarding `python-tools.sh`: Commit 55060486 satisfies yapf in some places of the source code, but in others not anylonger. So patch `python-tools.sh`'s newline handling again. While not thematically similar, both fixes get baked into one commit to satisfy the requirement that every single commit needs to pass `make clean all check test` individually.

Jan Lindemann added 1 commit 2026-06-25 17:35:51 +02:00

test/ .. /help: Fail over missing toplevel "make all" ... 6ab084ff44

The help integration test currently only succeeds because CI doesn't run "make all" before "make test". That way, the checked out repository lacks the generated __init__.py files needed for some modular subcommands to be fully loaded, and hence, the test should have failed. The entire machinery only worked because the subcommands in question are not not essential to building jw-pkg itself: "secrets" and "posix"
The fix is to
1. Change CI to run "make all" before "make test" (not here) 2. Fix the test in jw-pkg
Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-06-25 17:35:56 +02:00

Jan Lindemann force-pushed jan/feature/20260625-test-help-fail-over-missing-toplevel-make-all from 6ab084ff44 to 57180e3596 2026-06-25 18:21:22 +02:00 Compare

Jan Lindemann canceled auto merging this pull request when all checks succeed 2026-06-25 18:25:45 +02:00

Jan Lindemann force-pushed jan/feature/20260625-test-help-fail-over-missing-toplevel-make-all from 57180e3596 to 45f8e8cc89 2026-06-25 18:49:54 +02:00 Compare

Jan Lindemann changed title from test/ .. /help: Fail over missing toplevel make all to Targets make check + make test: Fix fallout of prior toplevel "make all" 2026-06-25 18:50:47 +02:00

Jan Lindemann merged commit 45f8e8cc89 into master 2026-06-25 18:53:15 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

janware/jw-pkg!37

No description provided.