Beautify logging code and output #17

Merged

Jan Lindemann merged 5 commits from jan/feature/20260617-beautify-logging-code-and-output into master 2026-06-17 17:19:39 +02:00 AGit

Conversation 0 Commits 5 Files changed 8 +391 -113

Jan Lindemann commented 2026-06-17 17:12:43 +02:00

Owner

Copy link

The biggest change this pull request introduces is integrating jw-python's log module, which makes for much nicer logging. The PR also adds some smaller fixes and enhancements in logging-related code.

lib.Types.LoadTypes: Beautify logging code

Shorten redundant occurences of .format(mod_name, member_name).

lib.Types.LoadTypes: Loosen type_filter type

In LoadTypes' constructor, allow the type_filter parameter to be of type Sequence[type[Any]] instead of list[type[T]]. a) Sequence is more generic than list, and b) with T instead of Any, trying to instantiate with an abstract class has mypy complain:

E: Only concrete class can be given where "type[MyClass]" is expected  [type-abstract]

  - type_filter: list[type[T]] = [],
  + type_filter: Sequence[type[Any]] | None = None,

Note that this makes mypy complain that it needs an annotation at the places where LoadTypes is used.

log: Use jw-python's log implementation

Use the (mostly) call-compatible log implementation from jw-python. This buys us much nicer logs with color and source-code positon annotations.

lib.Result: Fill "cmd" ctor parameter

Commands executed by ExecContext and its derived classes don't populate the "cmd" parameter of "Result"'s constructor. Fixing that makes for nicer error messages.

lib.App.run(): Use pretty_cmd() for logging command line

The command line jw-pkg.py is run with is logged with level "debug", and reconstructed with ' '.join(sys.argv). Use pretty_cmd() instead, this adds quotes around spaces.

The biggest change this pull request introduces is integrating jw-python's log module, which makes for much nicer logging. The PR also adds some smaller fixes and enhancements in logging-related code. #### lib.Types.LoadTypes: Beautify logging code Shorten redundant occurences of .format(mod_name, member_name). #### lib.Types.LoadTypes: Loosen type_filter type In LoadTypes' constructor, allow the type_filter parameter to be of type Sequence[type[Any]] instead of list[type[T]]. a) Sequence is more generic than list, and b) with T instead of Any, trying to instantiate with an abstract class has mypy complain: ``` E: Only concrete class can be given where "type[MyClass]" is expected [type-abstract] - type_filter: list[type[T]] = [], + type_filter: Sequence[type[Any]] | None = None, ``` Note that this makes mypy complain that it needs an annotation at the places where LoadTypes is used. #### log: Use jw-python's log implementation Use the (mostly) call-compatible log implementation from jw-python. This buys us much nicer logs with color and source-code positon annotations. #### lib.Result: Fill "cmd" ctor parameter Commands executed by ExecContext and its derived classes don't populate the "cmd" parameter of "Result"'s constructor. Fixing that makes for nicer error messages. #### lib.App.run(): Use pretty_cmd() for logging command line The command line jw-pkg.py is run with is logged with level "debug", and reconstructed with ' '.join(sys.argv). Use pretty_cmd() instead, this adds quotes around spaces.

Jan Lindemann added 5 commits 2026-06-17 17:12:43 +02:00

lib.Types.LoadTypes: Beautify logging code ... a3279a3b00

Shorten redundant occurences of .format(mod_name, member_name).
Signed-off-by: Jan Lindemann <jan@janware.com>

lib.Types.LoadTypes: Loosen type_filter type ... fd008b0a73

In LoadTypes' constructor, allow the type_filter parameter to be of type Sequence[type[Any]] instead of list[type[T]]. a) Sequence is more generic than list, and b) with T instead of Any, trying to instantiate with an abstract class has mypy complain:
  # E: Only concrete class can be given where "type[MyClass]" is
    expected  [type-abstract]
- type_filter: list[type[T]] = [], + type_filter: Sequence[type[Any]] | None = None,
Not that this makes mypy complain that it needs an annotation at the places where LoadTypes is used.
Signed-off-by: Jan Lindemann <jan@janware.com>

log: Use jw-python's log implementation ... 0386c351a9

Use the (mostly) call-compatible log implementation from jw-python. This buys us much nicer logs with color and source-code positon annotations.
Signed-off-by: Jan Lindemann <jan@janware.com>

lib.Result: Fill "cmd" ctor parameter ... 048726a1aa

Commands executed by ExecContext and its derived classes don't populate the "cmd" parameter of "Result"'s constructor. Fixing that makes for nicer error messages.
Signed-off-by: Jan Lindemann <jan@janware.com>

lib.App.run(): Use pretty_cmd() for logging command line ... 7088e33cfe

The command line jw-pkg.py is run with is logged with level "debug", and reconstructed with ' '.join(sys.argv). Use pretty_cmd() instead, this adds quotes around spaces.
Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-06-17 17:14:29 +02:00

Jan Lindemann merged commit 7088e33cfe into master 2026-06-17 17:19:39 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

janware/jw-pkg!17

No description provided.