janware/jw-pkg
1
Code Pull requests Activity Actions

cmds and lib: Don't print() log messages

Browse source 
print() should be used to output information requested by a certain command, but not for logging the process to achieve it. log() should be used for the latter. The current code has the distinction not down clearly, fix that.
Signed-off-by: Jan Lindemann <jan@janware.com>
This commit is contained in:
Jan Lindemann 2026-03-25 11:38:29 +01:00
commit 9b6ec109a1
3 changed files with 13 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/python/jw/pkg/cmds/projects/CmdCheck.py
View file

@ -19,6 +19,6 @@ class CmdCheck(Cmd): # export
async def _run(self, args: Namespace) -> None:
path = self.app.find_circular_deps(args.module, args.flavour)
if path:
print(f'Found circular dependency in flavour {args.flavour}:', ' -> '.join(path))
log(NOTICE, f'Found circular dependency in flavour {args.flavour}:', ' -> '.join(path))
exit(1)
print(f'No circular dependency found for flavour {args.flavour} in modules:', ' '.join(args.module))
log(NOTICE, f'No circular dependency found for flavour {args.flavour} in modules:', ' '.join(args.module))